Tempo CLI: Add a simple command to convert parquet schemas #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com> TraceIDText: snappy -> delta Signed-off-by: Joe Elliott <number101010@gmail.com> Kind: delta -> dict Signed-off-by: Joe Elliott <number101010@gmail.com> Columns: -snappy Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
This reverts commit 7fd047a.
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
mdisibio,
mapno,
kvrhdn and
zalegrala
as code owners
art-licis
reviewed
Sep 3, 2022
| return err | ||
| } | ||
|
|
||
| // copy a rowgroup at a time |
There was a problem hiding this comment.
Would it make sense to add some output to command execution, possibly progress over len(pf.RowGroups) processed? (Percentage or 'x out of n processed' - based on some time interval).
There was a problem hiding this comment.
Thanks for the suggestion. Added some progress messages.
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
tempo-cli util convertthat will convert a parquet data file from one schema to another.