Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change spanmetrics metric names and labels to match OTel conventions #1478

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

mapno
Copy link
Member

@mapno mapno commented Jun 8, 2022

What this PR does:

Changes spanmetric's metric names and labels to match OTel's spanmetrics spec.

Which issue(s) this PR fixes:
Fixes #1444

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@kvrhdn
Copy link
Member

kvrhdn commented Jun 9, 2022

Oh just a though, should we add a list of changes to the changelog so it's easy for people to find out what metrics/labels to change?

Something like this list: grafana/grafana#48654 (comment)

@joe-elliott
Copy link
Member

Agree with adding the metric name changes to the changelog. We often add details like that:

tempo/CHANGELOG.md

Lines 53 to 76 in 02a945d

* [ENHANCEMENT] Add hedging to queries to external endpoints. [#1350](https://github.com/grafana/tempo/pull/1350) (@joe-elliott)
New config options and defaults:
```
querier:
search:
external_hedge_requests_at: 5s
external_hedge_requests_up_to: 3
```
** BREAKING CHANGE **
Querier options related to search have moved under a `search` block:
```
querier:
search_query_timeout: 30s
search_external_endpoints: []
search_prefer_self: 2
```
becomes
```
querier:
search:
query_timeout: 30s
prefer_self: 2
external_endpoints: []
```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tempo Metrics Generation uses different metrics labels to Grafana Agent
3 participants