Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Data Encoding #1211

Merged
merged 14 commits into from
Jan 7, 2022
Merged

Refactor: Data Encoding #1211

merged 14 commits into from
Jan 7, 2022

Conversation

joe-elliott
Copy link
Member

What this PR does:
Adds some structure to the model package and includes a new abstraction to encapsulate new encodings. This PR lays the groundwork for a new encoding that will improve search times.

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Copy link
Contributor

@mdisibio mdisibio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is good cleanup, definitely appreciate the rename to liveTrace and the distinct encoding packages. Left a few comments/questions.

pkg/model/v0/decoder.go Show resolved Hide resolved
pkg/model/encoding.go Outdated Show resolved Hide resolved
pkg/model/v1/decoder.go Show resolved Hide resolved
pkg/model/v0/decoder.go Show resolved Hide resolved
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit 5d62b1a into grafana:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants