Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tempo-mixin: add panel for Envoy Proxy sidecar, update tanka example … #1137

Merged
merged 3 commits into from
Nov 26, 2021
Merged

tempo-mixin: add panel for Envoy Proxy sidecar, update tanka example … #1137

merged 3 commits into from
Nov 26, 2021

Commits on Nov 25, 2021

  1. tempo-mixin: add panel for Envoy Proxy sidecar, update tanka example … 

    …and jsonnet dependencies

Changes:

### Tempo / Writes dashboard

Add a panel with Envoy metrics. This panel is to be used when the gateway is run with an Envoy Proxy sidecar (for HTTP2 load balancing).
The metrics from Envoy expose the gRPC status codes, which are essential pieces of information when debugging ingress issues. The gateway only reports HTTP statuses, which is deceptive since a 200 OK HTTP packet might contain a gRPC message with an error.
Example: if a request is denied by the ingester because it hits the limit, the distributor will return a HTTP 200 OK message containg a gRPC message with status 9 FAILED PRECONDITION.

I've also added a text panel listing the gRPC status codes since these aren't common knowledge.
It links to this doc: https://github.com/grpc/grpc/blob/master/doc/statuscodes.md

### tanka example

- update prometheus config to always add `cluster` label, the tempo-mixin dashboards depend on this label
- enable search in Grafana and Tempo
- use a relative link to tempo-mixin, this makes it easier to quickly test changes

I've also run `jb update` in tempo-mixin and tk examples, hence the large amount of vendor file being changed.
    @kvrhdn
    kvrhdn committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    8756086 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @kvrhdn
    kvrhdn committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    9f0220b View commit details
    Browse the repository at this point in the history

  3. Regenerate tempo-mixin/yamls

    @kvrhdn
    kvrhdn committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    fffd076 View commit details
    Browse the repository at this point in the history