Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create-plugin: Make baseURL absolute and bump swc/core #424

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mikkancso
Copy link
Contributor

What this PR does / why we need it:

See my comment here: #344 (comment)

Which issue(s) this PR fixes:

Relates to #344

Special notes for your reviewer:

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2023

CLA assistant check
All committers have signed the CLA.

@mikkancso
Copy link
Contributor Author

FTR: here's a PR with the fix in our plugin https://github.com/grafana/cloud-onboarding/pull/5065

@academo academo added create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged labels Oct 4, 2023
@academo academo self-assigned this Oct 4, 2023
Copy link
Member

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working.

@academo academo merged commit b563b19 into main Oct 4, 2023
3 checks passed
@academo academo deleted the fix-baseurl-absolute-path-for-swc branch October 4, 2023 09:05
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@2.0.2 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants