Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k6 logo #3946

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Update k6 logo #3946

merged 4 commits into from
Sep 12, 2024

Conversation

mstoykov
Copy link
Contributor

What?

image
to
image

Why?

Updating the banner logo.

Terminal colors are user configurable so on my terminal "yellow" is ... green :P

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.54.0 milestone Sep 12, 2024
@mstoykov mstoykov requested a review from a team as a code owner September 12, 2024 07:38
@mstoykov mstoykov requested review from olegbespalov and joanlopez and removed request for a team September 12, 2024 07:38
olegbespalov
olegbespalov previously approved these changes Sep 12, 2024
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image

@joanlopez
Copy link
Contributor

joanlopez commented Sep 12, 2024

image
LGTM!

PS: My terminal identifies /\ as a link, but it's alright!

joanlopez
joanlopez previously approved these changes Sep 12, 2024
Copy link
Contributor

@federicotdn federicotdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move the 'Grafana' one char back so that it aligns with the 'k' :)

lib/consts/consts.go Outdated Show resolved Hide resolved
@mstoykov
Copy link
Contributor Author

@joanlopez does that happen for the previous version as well?

Co-authored-by: Federico Tedin <federicotdn@users.noreply.github.com>
lib/consts/consts.go Outdated Show resolved Hide resolved
@joanlopez
Copy link
Contributor

joanlopez commented Sep 12, 2024

@joanlopez does that happen for the previous version as well?

Yeah, yeah. I just mentioned it to clarify the screenshot, as "it's something expected"
Sorry for the confusion 🙏🏻

@mstoykov mstoykov merged commit 547fc08 into master Sep 12, 2024
22 checks passed
@mstoykov mstoykov deleted the updateK6Logo branch September 12, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants