Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop experimental timers #3838

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Drop experimental timers #3838

merged 1 commit into from
Sep 10, 2024

Conversation

mstoykov
Copy link
Contributor

What?

Drop k6/experimental/timers

Why?

We have stabilized the API and it is now available for k6/timers for some time. We would like to stop supporting the old import path.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.54.0 milestone Jul 11, 2024
@mstoykov mstoykov requested a review from a team as a code owner July 11, 2024 13:55
@mstoykov mstoykov requested review from olegbespalov and joanlopez and removed request for a team July 11, 2024 13:55
@mstoykov mstoykov changed the base branch from master to timersDeprecationWarningUpdate July 11, 2024 13:55
@mstoykov mstoykov added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Jul 11, 2024
joanlopez
joanlopez previously approved these changes Jul 11, 2024
Base automatically changed from timersDeprecationWarningUpdate to master July 11, 2024 14:31
@mstoykov mstoykov dismissed joanlopez’s stale review July 11, 2024 14:31

The base branch was changed.

@olegbespalov olegbespalov added the documentation-needed A PR which will need a separate PR for documentation label Sep 3, 2024
@mstoykov mstoykov merged commit 5f36e9b into master Sep 10, 2024
23 checks passed
@mstoykov mstoykov deleted the dropExperimentalTimers branch September 10, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes documentation-needed A PR which will need a separate PR for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants