Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'streams' variable & test renames #3785

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Missing 'streams' variable & test renames #3785

merged 1 commit into from
Jun 10, 2024

Conversation

joanlopez
Copy link
Contributor

What?

It addresses #3740 (comment)

Why?

Forgotten after a UI-through rename suggestion.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@joanlopez joanlopez requested a review from codebien June 10, 2024 07:45
@joanlopez joanlopez self-assigned this Jun 10, 2024
@joanlopez joanlopez requested a review from a team as a code owner June 10, 2024 07:45
@joanlopez joanlopez requested review from olegbespalov and removed request for a team June 10, 2024 07:45
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (73aaa79) to head (465b8db).

Current head 465b8db differs from pull request most recent head c9a4072

Please upload reports for the commit c9a4072 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3785      +/-   ##
==========================================
- Coverage   71.88%   71.86%   -0.02%     
==========================================
  Files         291      291              
  Lines       21249    21249              
==========================================
- Hits        15274    15270       -4     
- Misses       4913     4917       +4     
  Partials     1062     1062              
Flag Coverage Δ
ubuntu 71.78% <100.00%> (-0.03%) ⬇️
windows 71.72% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov added this to the v0.52.0 milestone Jun 10, 2024
@joanlopez joanlopez merged commit 44d7840 into master Jun 10, 2024
23 checks passed
@joanlopez joanlopez deleted the streams-rename branch June 10, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants