Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issues in api package #3485

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix lint issues in api package #3485

merged 1 commit into from
Dec 7, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Dec 1, 2023

works on #769

This also fixes a bug where we always logged all responses were 200 ... 🤦

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (856a767) 73.22% compared to head (b738d6c) 73.22%.

❗ Current head b738d6c differs from pull request most recent head 0a68fa8. Consider uploading reports for the commit 0a68fa8 to get more accurate results

Files Patch % Lines
api/server.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3485   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         267      267           
  Lines       20083    20083           
=======================================
  Hits        14706    14706           
  Misses       4463     4463           
  Partials      914      914           
Flag Coverage Δ
ubuntu 73.16% <50.00%> (ø)
windows 73.07% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mstoykov mstoykov merged commit cb09e1a into master Dec 7, 2023
22 checks passed
@mstoykov mstoykov deleted the lintFixAPIPackage branch December 7, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants