cloudv2/hdr: Fix off-by-one error for spans #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
previously approved these changes
Jul 10, 2023
codebien
force-pushed
the
fix-cloudv2-hdr-span-gap
branch
from
0e88025
to
ddf3120
Compare
histogram.Spans.Offset is expected to be the counter of the empty buckets and not the diff between the indexes. i.e., when encoding a sequence like the following: [1, 1, 1, 0, 2, 2] The second span must be: (offset=1, length=2) And not: (offset=2, length=2)
codebien
force-pushed
the
fix-cloudv2-hdr-span-gap
branch
from
ddf3120
to
aeb50b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #3182 +/- ##
=======================================
Coverage 72.78% 72.79%
=======================================
Files 256 256
Lines 19697 19697
=======================================
+ Hits 14337 14338 +1
+ Misses 4464 4463 -1
Partials 896 896
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mstoykov
approved these changes
Jul 10, 2023
olegbespalov
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the histogram's Spans encoding.
i.e., when encoding a sequence like the following:
[1, 1, 1, 0, 2, 2]The second span must be:
(offset=1, length=2)And not:
(offset=2, length=2)Why
histogram.Spans.Offsetis expected to be the counter of the empty buckets and not the diff between the indexes.Related PR(s)/Issue(s)
Follow-up on #3169