Add tests covering v0.38.* thresholds regressions #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na--
previously approved these changes
Jun 10, 2022
|
though you should probably change the PR description to "closes #2525", so the issue will be closed automatically once the PR is merged |
mstoykov
previously approved these changes
Jun 10, 2022
olegbespalov
previously approved these changes
Jun 10, 2022
oleiade
dismissed stale reviews from olegbespalov, mstoykov, and na--
via
59fab4b
oleiade
force-pushed
the
test/thresholds_regressions_tests
branch
from
59fab4b
to
6cb07e9
Compare
oleiade
force-pushed
the
test/thresholds_regressions_tests
branch
from
6cb07e9
to
0ef355e
Compare
na--
approved these changes
Jun 13, 2022
mstoykov
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses #2525 and adds tests covering the thresholds-related regressions observed in
v0.38.*versions as a result of further replacement of the thresholds' evaluation logic.Specifically, this PR adds tests covering #2518, #2512 and #2520.
I've tried different approaches for testing, but adding test scripts illustrating the issue, and writing tests for the
runcommand, just like with did for thresholds validation at init ended up being the simplest, clearest and most convenient.closes #2525