Fix the parsing of threshold name tags containing tokens #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@efdknittlfrank pointed out that v0.38.0 presented a bug when thresholds were defined for URL grouping. Indeed, using colons and curly braces inside of a thresholds tags definition would confuse the parser, and lead to an unclear error. This commit ensures that we parse thresholds tags properly: * closing curly brace is now parsed from the right * we ensure the closing curly brace is the last character in the string. * knowing the position of the opening an closing tag definition curly braces, we extract the whole definition's substring based on that.
oleiade
force-pushed
the
hotfix/0.38.0/thresholds-url-grouping-parsing
branch
from
39828ee
to
7b57242
Compare
oleiade
force-pushed
the
hotfix/0.38.0/thresholds-url-grouping-parsing
branch
from
4caf161
to
652f7be
Compare
na--
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@efdknittlfrank pointed out that v0.38.0 presented a bug when thresholds were defined following the URL grouping documentation.
Indeed, using colons and curly braces inside a thresholds tags definition would confuse the parser, and
lead to an unclear error message. This PR modifies the parser to handle curly braces and colons accordingly to the pointed out use case. Namely, the parser makes fewer assumptions as to the tags definitions' content, and allows for a wider range of symbols that would have conflicted with the parsing before
{,},:.A threshold expression such as
http_req_duration{name:http://${}.com}is now valid.Notable changes:
braces, we extract the whole definition's substring based on that.
closes #2512