Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update CONTRIBUTING.md #2437

Merged
merged 5 commits into from
Apr 14, 2022
Merged

chore: update CONTRIBUTING.md #2437

merged 5 commits into from
Apr 14, 2022

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Mar 11, 2022 •
edited
Loading

What?

This PR is updating the CONTRIBUTING.md

Also, WDYT if we add the Makefile's target with the tooling installation?

Changelog

CONTRIBUTING.md was actualized.

@olegbespalov olegbespalov self-assigned this Mar 11, 2022
@olegbespalov olegbespalov added this to the v0.38.0 milestone Mar 11, 2022
codebien
codebien requested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one simple request

Makefile Outdated Show resolved Hide resolved
mstoykov
mstoykov reviewed Mar 11, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
javaducky
javaducky reviewed Mar 11, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
javaducky
javaducky previously approved these changes Mar 12, 2022
View reviewed changes
codebien
codebien previously approved these changes Mar 14, 2022
View reviewed changes
mstoykov
mstoykov requested changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace all slack mentions with the community forum?

mstoykov
mstoykov reviewed Mar 14, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
mstoykov
mstoykov reviewed Mar 14, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
mstoykov
mstoykov reviewed Mar 14, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
mstoykov
mstoykov reviewed Mar 14, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
oleiade
oleiade requested changes Mar 14, 2022
View reviewed changes
Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments 😸

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@olegbespalov olegbespalov dismissed stale reviews from codebien and javaducky via 64c1b1b April 13, 2022 15:22
olegbespalov and others added 4 commits April 13, 2022 17:22
@olegbespalov
chore: update CONTRIBUTING.md
e264ff2
@olegbespalov
chore: apply code review changes
65b3fd8
@olegbespalov @mstoykov @oleiade
Apply suggestions from code review
874abb2 
Co-authored-by: Mihail Stoykov <MStoykov@users.noreply.github.com>
Co-authored-by: Théo Crevon <oleiade@users.noreply.github.com>
@olegbespalov
chore: apply suggestions
8692f56
javaducky
javaducky previously approved these changes Apr 13, 2022
View reviewed changes
mstoykov
mstoykov previously approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have listed some more changes, but am fine with merging it as is and making them later.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@olegbespalov olegbespalov dismissed stale reviews from mstoykov and javaducky via 412ec92 April 14, 2022 07:45
@olegbespalov olegbespalov mentioned this pull request Apr 14, 2022
Closed
@olegbespalov olegbespalov merged commit 57e9942 into master Apr 14, 2022
@olegbespalov olegbespalov deleted the chore/contributing-updates branch April 14, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

@oleiade oleiade oleiade approved these changes

@javaducky javaducky javaducky approved these changes

@codebien codebien codebien approved these changes

Assignees

@olegbespalov olegbespalov

Labels
docs
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging this pull request may close these issues.
5 participants
@olegbespalov @mstoykov @oleiade @javaducky @codebien