Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: move deps and lint jobs only on pull requests #2403

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Feb 28, 2022

This was provoked as the new use of golangci-lint action fails on master
with all the lint errors there. But in reality it's probably not needed
to run those tasks on master - they are mostly about new code

This was provoked as the new use of golangci-lint action fails on master
with all the lint errors there. But in reality it's probably not needed
to run those tasks on master - they are mostly about new code
olegbespalov
olegbespalov previously approved these changes Feb 28, 2022
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove lint from the needs: lists in all.yml

@mstoykov mstoykov merged commit fb57be0 into master Mar 1, 2022
@mstoykov mstoykov deleted the lintOnlyOnBranches branch March 1, 2022 07:51
@mstoykov mstoykov added this to the v0.37.0 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants