Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent panic on not providing second argument to check #2387

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Prevent panic on not providing second argument to check #2387

merged 4 commits into from
Feb 17, 2022

Conversation

mstoykov
Copy link
Contributor

No description provided.

@mstoykov mstoykov added this to the v0.37.0 milestone Feb 15, 2022
olegbespalov
olegbespalov reviewed Feb 15, 2022
View reviewed changes
js/modules/k6/k6.go Outdated Show resolved Hide resolved
olegbespalov
olegbespalov reviewed Feb 15, 2022
View reviewed changes
js/modules/k6/k6.go Outdated Show resolved Hide resolved
na--
na-- reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I agree with @olegbespalov's comment.

olegbespalov
olegbespalov approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mstoykov mstoykov merged commit 737dfa7 into master Feb 17, 2022
@mstoykov mstoykov deleted the preventPanicInCheck branch February 17, 2022 12:00
@codebien codebien mentioned this pull request Feb 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na-- na-- na-- approved these changes

@olegbespalov olegbespalov olegbespalov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.37.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @na-- @olegbespalov