Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed documentation #2169

Merged
merged 1 commit into from
Oct 11, 2021
Merged

fixed documentation #2169

merged 1 commit into from
Oct 11, 2021

Conversation

marooncoder09
Copy link
Contributor

Fixed Grammatical and punctuational errors in the README.md file

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #2169 (5c693a0) into master (42f2e60) will increase coverage by 0.01%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
+ Coverage   72.71%   72.73%   +0.01%     
==========================================
  Files         184      184              
  Lines       14571    14577       +6     
==========================================
+ Hits        10596    10602       +6     
  Misses       3333     3333              
  Partials      642      642              
Flag Coverage Δ
ubuntu 72.67% <68.42%> (+0.02%) ⬆️
windows 72.37% <68.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/login_cloud.go 0.00% <0.00%> (ø)
cmd/login_influxdb.go 0.00% <0.00%> (ø)
cmd/ui.go 20.61% <0.00%> (ø)
lib/metrics/metrics.go 100.00% <ø> (ø)
ui/form_fields.go 45.71% <0.00%> (ø)
output/csv/config.go 74.00% <100.00%> (+4.23%) ⬆️
output/csv/output.go 67.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed18b26...5c693a0. Read the comment docs.

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebien codebien merged commit fd316f0 into grafana:master Oct 11, 2021
@@ -374,7 +374,7 @@ You can save the above example as a local file and run it, or you can also run i

To make full use of your test results and to be able to fully explore and understand them, k6 can output the raw metrics to an external repository of your choice.

The simplest output option, meant primarily for debugging, is to send the JSON-encoded metrics to a file or to `stdout`. Other output options are sending the metrics to an InfluxDB instance, an Apache Kafka queue, or even to the k6 cloud. This allows you to run your load tests locally or behind a company firewall, early in the development process or as a part of a CI suite, while at the same time being able store their results in the k6 cloud, where you can compare and analyse them. You can find more information about the available outputs [here](https://k6.io/docs/getting-started/results-output) and about k6 Cloud Results [here](https://k6.io/docs/getting-started/results-output/cloud) and [here](https://k6.io/docs/cloud/analyzing-results/overview).
The simplest output option, meant primarily for debugging, is to send the JSON-encoded metrics to a file or to `stdout`. Other output options are sending the metrics to an InfluxDB instance, an Apache Kafka queue, or even to the k6 cloud. This allows you to run your load tests locally or behind a company firewall, early in the development process or as a part of a CI suite, while at the same time being able to store their results in the k6 cloud, where you can compare and analyse them. You can find more information about the available outputs [here](https://k6.io/docs/getting-started/results-output) and about k6 Cloud Results [here](https://k6.io/docs/getting-started/results-output/cloud) and [here](https://k6.io/docs/cloud/analyzing-results/overview).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggestion:
is to send the JSON-encoded metrics to a file or to stdout.

So:
is to send the JSON-encoded metrics to a file or stdout.

@FloorD
Copy link
Contributor

FloorD commented Oct 11, 2021

Thank you for your contribution, @marooncoder09. We would love to send you a little swag pack as a token of our appreciation. Please get in touch with me via floor[@]grafana.com!

@marooncoder09
Copy link
Contributor Author

Thank you for your contribution, @marooncoder09. We would love to send you a little swag pack as a token of our appreciation. Please get in touch with me via floor[@]grafana.com!

Thank You @FloorD Loved to be the part of this organisation can you please elaborate a further how can I reach you ?

@mstoykov mstoykov added this to the v0.35.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants