Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass setup data object into handleSummary callback #2103

Merged
merged 8 commits into from
Aug 27, 2021
Merged

Pass setup data object into handleSummary callback #2103

merged 8 commits into from
Aug 27, 2021

Commits on Jul 31, 2021

  1. Pass setup data object into handleSummary callback 

    Issue: grafana#2088
    @sammieboy97
    sammieboy97 committed Jul 31, 2021
    Configuration menu
    Copy the full SHA
    d55e663 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. Added tests for passing setup data to handleSummary callback

    @sammieboy97
    sammieboy97 committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    29d6caf View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Returning m instead of nil when error during unmarshal

    @sammieboy97
    sammieboy97 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    adb4a7e View commit details
    Browse the repository at this point in the history

  2. Update js/summary_test.go 

    Checking error before

Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
    @sammieboy97 @codebien
    sammieboy97 and codebien committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    7ff0af6 View commit details
    Browse the repository at this point in the history

  3. Update js/summary_test.go 

    check error after the test.

Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
    @sammieboy97 @codebien
    sammieboy97 and codebien committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    c589244 View commit details
    Browse the repository at this point in the history

  4. Removed logs in test 

    Reverted the newline in import
    @sammieboy97
    sammieboy97 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    e8f0410 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Lint formatting

    @sammieboy97
    sammieboy97 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    96b62c8 View commit details
    Browse the repository at this point in the history

  2. Added gofumpt format (lint)

    @sammieboy97
    sammieboy97 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    c309910 View commit details
    Browse the repository at this point in the history