Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing CookieJar to WebSocket through Params #1226

Closed
assembly-adrianlai opened this issue Nov 5, 2019 · 3 comments
Closed

Support passing CookieJar to WebSocket through Params #1226

assembly-adrianlai opened this issue Nov 5, 2019 · 3 comments

Comments

@assembly-adrianlai
Copy link

The ws library is not passing the Cookie jar to the Websocket connection.

The server we have is using the cookie in the request to pull out the necessary variables to establish the websocket

The underlying Go library seems to support it but it is ignored and dropped when establishing the WS.

It would be create to support it.

@na-- na-- added the bug label Nov 11, 2019
@na-- na-- added this to the v0.27.0 milestone Nov 11, 2019
@na--
Copy link
Member

na-- commented Nov 11, 2019

Thanks for reporting this! Looking at the current websocket connection code, I can't find any mention of cookies 😞 We need to fix this, though at this point I'm not sure if it wouldn't be a medium-sized breaking change rather than a bugfix, if we just started automatically using the global VU cookie jar 🤦‍♂️ So maybe we should just add the option to specify one manually?

In either case, until we fix this, it seems like the only workaround for this issue is to manually specify the Cookie header value in the WS params' headers option...

@assembly-adrianlai
Copy link
Author

Thanks for that, with that workaround, it requires changes to the code on the websocket listener to take the cookies from the header as opposed to the Cookie Jar depending on how the server code was
built which is not ideal but workable for now.

Hope this makes it into a bugfix version soon!

@na-- na-- modified the milestones: v0.27.0, v0.28.0 May 21, 2020
@na-- na-- modified the milestones: v0.28.0, v0.29.0 Sep 9, 2020
@na-- na-- modified the milestones: v0.29.0, v0.30.0 Nov 4, 2020
@na-- na-- modified the milestones: v0.30.0, v0.31.0 Jan 13, 2021
@na-- na-- modified the milestones: v0.31.0, v0.32.0 Mar 5, 2021
This was referenced Mar 23, 2021
@na-- na-- modified the milestones: v0.32.0, v0.33.0 Apr 14, 2021
imiric pushed a commit that referenced this issue Jun 8, 2021
@na-- na-- modified the milestones: v0.33.0, v0.34.0 Jun 16, 2021
@mstoykov mstoykov modified the milestones: v0.34.0, v0.35.0 Sep 1, 2021
@mstoykov
Copy link
Contributor

fixed by #2193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants