Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update after native ESM support #1688

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Update after native ESM support #1688

merged 1 commit into from
Aug 12, 2024

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Aug 8, 2024

What?

Update after ESM is now natively supported.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

@ppcano
Copy link
Collaborator

ppcano commented Aug 11, 2024

LGTM, I share some thoughts for later consideration:

1 - The guides are versioned, so I am unsure if it is desired to mention specific version changes After v0.53.0....
On the other hand, it may be desired b/c users tend to read the latest version. This is why we decided time ago to remove these references after two releases.

2 - --compatibility-mode=base is now a very rare case. I think we could drop the documentation about this option, and leave the versioned docs for older references.

3 - About --compatibility-mode=experimental_enhanced. I shared this before and don't know exactly the future plan, but we could rename this option to just typescript... or mode=typescript

@mstoykov mstoykov merged commit 5746fe9 into main Aug 12, 2024
5 checks passed
@mstoykov mstoykov deleted the ESMchanges branch August 12, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants