Explore/Logs: Alphabetically sort unique labels, labels and parsed fields #29030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
requested review from
a team,
peterholmberg,
kaydelaney,
davkal,
zoltanbedi and
aocenas
and removed request for
a team,
peterholmberg and
kaydelaney
aocenas
approved these changes
Nov 12, 2020
Elfo404
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Looks good! 🚀
Just an idea: did you consider doing a case-insensitive sort instead?
with very little effort it may improve user experience even more, something like
const alphabeticallyInsensitive = (a: string, b: string) => a.toLowerCase().localeCompare(b.toLowerCase());wdyt?
EDIT: I just realized that maybe it doesn't make sense given the context, please ignore :)
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#22659 was mentioning sorting of unique labels in alphabetical order. I've also seen our internal users searching for labels/parsed fields, so I think this little change can have a nice impact for usability and search-ability trough labels and fields.
Which issue(s) this PR fixes:
Fixes #22659