Transformations: merge will properly handle empty frames and frames with multiple rows where values are overlapping. #27362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckn
changed the title
mckn
changed the title
peterholmberg
approved these changes
Sep 8, 2020
packages/grafana-data/src/transformations/transformers/merge.test.ts
Outdated
Show resolved
Hide resolved
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
…ith multiple rows where values are overlapping. (#27362) * wip. * Fixed issue with merge not behaving exactly as the old table panel did. * Fixed so empty data frames will be exluded prior to trying to merge the result. * Changed so if passing only empty frames first will only be returned. * de-duplication of configuration in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR resolves the issue reported in the following issues: #26908, #26890.
Prior to this fix, incoming data with the following format:
Query A:
Query B:
Did not properly merged right hand side values in to all matching row and the result was the following:
After applying this fix, the merge will return the following:
It will also handle the scenario where all incoming data frames are empty. In this scenario they will be merged into one single empty frame.
If only a couple of the incoming data frames are empty they will be removed prior to doing the merge. So all the frames containing data will be merged into one single frame.
Which issue(s) this PR fixes:
Fixes #26908
Fixes #26890