Templating: Fixes query variable with ${__searchFilter} value selection not causing refresh & url update #25770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
a team,
mckn and
tskarhed
and removed request for
a team
torkelo
commented
Jun 23, 2020
Comment on lines
+53
to
63
| const defaultMiddleware = getDefaultMiddleware<State>({ | ||
| thunk: false, | ||
| serializableCheck: false, | ||
| immutableCheck: false, | ||
| } as any); | ||
|
|
||
| const givenRootReducer = (rootReducer: Reducer<State>): ReduxTesterWhen<State> => { | ||
| store = configureStore<State>({ | ||
| reducer: rootReducer, | ||
| middleware: [...getDefaultMiddleware<State>(), logActionsMiddleWare, thunk] as [ThunkMiddleware<State>], | ||
| middleware: [...defaultMiddleware, logActionsMiddleWare, thunk] as [ThunkMiddleware<State>], | ||
| preloadedState, |
There was a problem hiding this comment.
This fixes the flooding of console log warnings about unserializable state in redux actions
mckn
approved these changes
Jun 24, 2020
torkelo
added a commit
that referenced
this pull request
Jun 24, 2020
(cherry picked from commit b7d26b1)
3 tasks
dprokop
pushed a commit
that referenced
this pull request
Jun 25, 2020
(cherry picked from commit b7d26b1)
aknuds1
pushed a commit
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25671