Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: Fixed share json modal issue introduced in merged PR 2 days ago #23607

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Dashboard: Fixed share json modal issue introduced in merged PR 2 days ago #23607

merged 1 commit into from
Apr 16, 2020

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Apr 16, 2020

Fixes #23605

hugohaggmark
hugohaggmark approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@hugohaggmark hugohaggmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected!

@dprokop dprokop merged commit 7fc9921 into master Apr 16, 2020
@dprokop dprokop deleted the fix-share-json branch April 16, 2020 07:31
bergquist added a commit that referenced this pull request Apr 17, 2020
@bergquist
Merge branch 'master' into dfp-internal-metrics
591f760 
* master: (139 commits)
  SAML Role and Team sync (open source part) (#23391)
  Transformers: fixes column names generated by seriesToColumn transformer (#23642)
  Table: add a select option when multiple tables exist (#23545)
  Tabs: adds counter component (#23548)
  UX: Minor style tweaks and fixes (#23614)
  Modals: Fixed alignment in header (#23618)
  revent optional event arg change (#23622)
  Build: Stricter linting should break the build (#23606)
  Docs: update users API (#23570)
  Explore: Prevents sizing issue when split (#23596)
  @grafana/ui: Various smaller Icon updates (#23588)
  Because alpine uses musl instead of libc, the e2e/cypress was not compatible (#23602)
  Backend Plugins: Discard logged messages from logger named stdio (#23601)
  Fixed share json (#23607)
  Linting fixes for provisoning (#23600)
  Image Rendering: Remove PhantomJS support (#23460)
  Storybook: Organizing (#23572)
  @grafana/ui: Remove ColorPallete component (#23592)
  Docs: Change header levels of last three sections (#23587)
  CircleCI: Upgrade the build pipeline tool (#23595)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugohaggmark hugohaggmark hugohaggmark approved these changes

@dprokop dprokop dprokop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard: sharing Dashboard JSON stopped working
3 participants
@torkelo @hugohaggmark @dprokop