StatPanels: Fixed change from singlestat to Gauge / BarGauge / Stat where default min & max (0, 100) was copied #21820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being copied even when gauge was disbled
dprokop
approved these changes
Jan 29, 2020
|
Maybe the PR title can be changed to a shorter one 😄 If we want to include in changelog that is |
torkelo
changed the title
|
updated title |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21818
The panel change hander did copy default gauge min and max from the angular singlestat even when not enabled. So when switching between visualizations the new react panels picked up min: 0 and max: 100 when switching from the singlestat panel