Explore: Fix timepicker when browsing back after switching datasource #21454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
requested review from
a team and
davkal
and removed request for
a team
Estrax
approved these changes
Jan 14, 2020
davkal
approved these changes
Jan 14, 2020
|
Since the fix uses the raw time range, should the payload types not change? See |
This resulted in change in Explore.ts where instead of supplying |
ivanahuckova
deleted the
ivanah/explore-fix-timepicker-when-going-back
branch
ryantxu
added a commit
that referenced
this pull request
Jan 15, 2020
…ation * origin/master: Explore: Fix timepicker when browsing back after switching datasource (#21454) Add disabled option for cookie samesite attribute (#21472) Chore: Adds basic alerting notification service tests (#21467) ImportDashboardCommand: Validate JSON fields (#21350) Docs: add test for website build (#21364) Fix: when clicking a plot on a touch device we won't display the annotation menu (#21479) Backend Plugins: add a common implementation (#21408) Alerting: new min_interval_seconds options to enforce a minimum eval frequency (#21188) Panel: Use Tabs in panel inspector (#21468)
johntdyer
pushed a commit
to johntdyer/grafana
that referenced
this pull request
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Browsing back after switching datasource used to change time picker (see issue).
This issue was caused by suppling incorrect argument in
initializeExplorefunction used inrefreshExplore. This function requiresrawRange, butrangewas supplied which resulted in the above mentioned bug. This PR fixes this.Which issue(s) this PR fixes:
Fixes #20933