Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudWatch: Region template query fix #20661

Merged
merged 2 commits into from
Nov 27, 2019
Merged

CloudWatch: Region template query fix #20661

merged 2 commits into from
Nov 27, 2019

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Nov 26, 2019

fixes #20659

@sunker sunker self-assigned this Nov 26, 2019
daniellee
daniellee reviewed Nov 26, 2019
View reviewed changes
Copy link
Contributor

@daniellee daniellee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a rule that would be good to add a test for? It is simple but perhaps not obvious to someone else in the future.

@marefr marefr added this to the 6.5.1 milestone Nov 26, 2019
daniellee
daniellee approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@daniellee daniellee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great. LGTM

@sunker sunker merged commit 116b618 into master Nov 27, 2019
@sunker sunker deleted the 20659-cw-template-query-fix branch November 27, 2019 16:06
hugohaggmark pushed a commit that referenced this pull request Nov 28, 2019
@sunker @hugohaggmark
CloudWatch: Region template query fix (#20661)
99b4d2b 
* Make region an optional parameter

* Test region template query

(cherry picked from commit 116b618)
@hugohaggmark hugohaggmark mentioned this pull request Nov 28, 2019
Merged
hugohaggmark pushed a commit that referenced this pull request Nov 28, 2019
@sunker @hugohaggmark
CloudWatch: Region template query fix (#20661)
e3db87d 
* Make region an optional parameter

* Test region template query

(cherry picked from commit 116b618)
@sunker sunker mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellee daniellee daniellee approved these changes

Assignees

@sunker sunker

Labels
datasource/CloudWatch type/bug
Projects
None yet
Milestone
6.5.1
Development

Successfully merging this pull request may close these issues.

CloudWatch: Template query function to get metric list partly broken
4 participants
@sunker @daniellee @hugohaggmark @marefr