Team Sync: Fix URL encode Group IDs for external team sync #20280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External Group IDs can have special characters. Encode them to make them URL-safe.
torkelo
approved these changes
Nov 8, 2019
marefr
changed the title
kylebrandt
pushed a commit
that referenced
this pull request
Nov 13, 2019
* Fix: URL Encode Group IDs for external team sync External Group IDs can have special characters. Encode them to make them URL-safe. (cherry picked from commit 7e96a57)
kylebrandt
pushed a commit
that referenced
this pull request
Nov 14, 2019
* Fix: URL Encode Group IDs for external team sync External Group IDs can have special characters. Encode them to make them URL-safe. (cherry picked from commit 7e96a57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Group IDs can have special characters. Encode them to make them
URL-safe.
What this PR does / why we need it:
Encodes the groupID to make it URL-safe as we issue a deletion
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/grafana-enterprise/issues/281
Special notes for your reviewer: