Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Allows the d-solo route to be used without slug #19640

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

97amarnathk
Copy link
Contributor

Removes the :slug fromt the routes and the API. This allows the Embedded URLs to work without requiring the dashboard name.

Which issue(s) this PR fixes:

Fixes #11617

pkg/api/api.go Show resolved Hide resolved
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes still needed.

public/app/routes/routes.ts Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Works as expected

@marefr marefr merged commit 74557a4 into grafana:master Oct 14, 2019
@marefr marefr added this to the 6.5 milestone Oct 14, 2019
@marefr
Copy link
Member

marefr commented Oct 14, 2019

@97amarnathk Thank you for contributing to Grafana!

Totally optional, but may I ask you if you're participating in Hacktoberfest and whether you've find this issue through the hacktoberfest label? Trying to find out if new contributors are finding Grafana due to Hacktoberfest.

@marefr marefr changed the title Removes :slug from the routes and the API Dashboard: Allows the d-solo route to be used without slug Oct 14, 2019
@97amarnathk
Copy link
Contributor Author

@marefr
Actually I started reading up on Go/Prometheus, and therefore Grafana came in my Github repositories reccomendation. Added to this, Hacktoberfest provided me motivation to get started with Grafana.

P.S. Can I get an issue to solve ? Something which is a bit more involved but has a sufficient enough learning curve for a beginner in Grafana and Go?

@marefr marefr added the hacktoberfest https://hacktoberfest.com/ label Oct 22, 2019
@marefr
Copy link
Member

marefr commented Oct 22, 2019

@97amarnathk thanks, that's great 😄

Maybe you can have a look here or here for issues that's labeled help wanted. Write a comment in an issue you would like to work on or are interested in and we'll get back to you with some additional pointers.

@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog hacktoberfest https://hacktoberfest.com/ pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded URL in 5.0 requires dashboard name
5 participants