correct volume unit #12744
Merged
correct volume unit #12744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marefr
requested changes
Jul 30, 2018
public/app/core/utils/kbn.ts
Outdated
| { text: 'milligram per normal cubic metre (mg/Nm3)', value: 'conmgNm3' }, | ||
| { text: 'gram per cubic metre (g/m3)', value: 'congm3' }, | ||
| { text: 'gram per normal cubic metre (g/Nm3)', value: 'congNm3' }, | ||
| { text: 'nanogram per normal cubic metre (ng/Nm³)', value: 'conngNm3' }, |
There was a problem hiding this comment.
You missed the one above nanogram per cubic metre (ng/m3)
|
Thank you for your first contribution to Grafana! Very appreciated! |
ryantxu
added a commit
to NatelEnergy/grafana
that referenced
this pull request
Aug 2, 2018
* grafana/master: (104 commits) Change to arrow functions Add all tests to one file changelog: add notes about closing grafana#12561 Remove angularMocks All tests passing changelog: add notes about closing grafana#12762 fix: team email tooltip was not showing fix: test data api route used old name for test data datasource, fixes grafana#12773 changelog: add notes about closing grafana#12300 Weird execution order for the tests... changelog: add notes about closing grafana#12744 changelog: add notes about closing grafana#12727 add aws_dx to cloudwatch datasource also fixed "Watt per square metre" fixed that missing one add version note to metric prefix and fix typo devenv: update sql dashboards mssql: update tests fix usage of metric column types so that you don't need to specify metric alias Begin conversion ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Aug 2, 2018
* grafana/master: (104 commits) Change to arrow functions Add all tests to one file changelog: add notes about closing grafana#12561 Remove angularMocks All tests passing changelog: add notes about closing grafana#12762 fix: team email tooltip was not showing fix: test data api route used old name for test data datasource, fixes grafana#12773 changelog: add notes about closing grafana#12300 Weird execution order for the tests... changelog: add notes about closing grafana#12744 changelog: add notes about closing grafana#12727 add aws_dx to cloudwatch datasource also fixed "Watt per square metre" fixed that missing one add version note to metric prefix and fix typo devenv: update sql dashboards mssql: update tests fix usage of metric column types so that you don't need to specify metric alias Begin conversion ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Aug 2, 2018
* grafana/master: (104 commits) Change to arrow functions Add all tests to one file changelog: add notes about closing grafana#12561 Remove angularMocks All tests passing changelog: add notes about closing grafana#12762 fix: team email tooltip was not showing fix: test data api route used old name for test data datasource, fixes grafana#12773 changelog: add notes about closing grafana#12300 Weird execution order for the tests... changelog: add notes about closing grafana#12744 changelog: add notes about closing grafana#12727 add aws_dx to cloudwatch datasource also fixed "Watt per square metre" fixed that missing one add version note to metric prefix and fix typo devenv: update sql dashboards mssql: update tests fix usage of metric column types so that you don't need to specify metric alias Begin conversion ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Aug 2, 2018
* grafana/master: (185 commits) Change to arrow functions Add all tests to one file changelog: add notes about closing grafana#12561 Remove angularMocks All tests passing changelog: add notes about closing grafana#12762 fix: team email tooltip was not showing fix: test data api route used old name for test data datasource, fixes grafana#12773 changelog: add notes about closing grafana#12300 Weird execution order for the tests... changelog: add notes about closing grafana#12744 changelog: add notes about closing grafana#12727 add aws_dx to cloudwatch datasource also fixed "Watt per square metre" fixed that missing one add version note to metric prefix and fix typo devenv: update sql dashboards mssql: update tests fix usage of metric column types so that you don't need to specify metric alias Begin conversion ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Aug 2, 2018
* grafana/master: (263 commits) Change to arrow functions Add all tests to one file changelog: add notes about closing grafana#12561 Remove angularMocks All tests passing changelog: add notes about closing grafana#12762 fix: team email tooltip was not showing fix: test data api route used old name for test data datasource, fixes grafana#12773 changelog: add notes about closing grafana#12300 Weird execution order for the tests... changelog: add notes about closing grafana#12744 changelog: add notes about closing grafana#12727 add aws_dx to cloudwatch datasource also fixed "Watt per square metre" fixed that missing one add version note to metric prefix and fix typo devenv: update sql dashboards mssql: update tests fix usage of metric column types so that you don't need to specify metric alias Begin conversion ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed 3 to ³