Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Don't hide graph display options (Lines/Points) when draw mode is unchecked #9770

Closed
cas-- opened this issue Nov 2, 2017 · 4 comments · Fixed by #10574
Closed

[UX] Don't hide graph display options (Lines/Points) when draw mode is unchecked #9770

cas-- opened this issue Nov 2, 2017 · 4 comments · Fixed by #10574

Comments

@cas--
Copy link

cas-- commented Nov 2, 2017

If you untick all draw modes and only set them in series override you will find that any mode options from the Draw options tab will still apply such a fill or line width even though they are hidden.

I would expect that if the Mode Options are hidden then it reverts to the defaults in series override.

The workaround is to go to Draw options tab, tick label, change all the mode options to the default values and then untick label.

Hosted grafana: https://niteo.grafana.net

@torkelo
Copy link
Member

torkelo commented Nov 2, 2017

Not sure reseting the options when you temporarily disable say lines is a good thing, think having those options still there makes sense as you frequently switch modes and experiment and constantly having them revert to default is not very nice.

@torkelo torkelo closed this as completed Nov 2, 2017
@cas--
Copy link
Author

cas-- commented Nov 2, 2017

Why is this being closed?

The mode options should not be hidden as it's bad UI design and not obvious where values are coming from

@cas--
Copy link
Author

cas-- commented Nov 2, 2017

I am not talking about actually resetting the values in options. What I mean is that if a mode is unticked in Draw options tab then the global options apply not the user set one that are now hidden. This is standard User Interface design.

@torkelo
Copy link
Member

torkelo commented Nov 2, 2017

your right, we can disable the hiding of the draw options instead

@torkelo torkelo reopened this Nov 2, 2017
@torkelo torkelo added this to the 4.7.0 milestone Nov 2, 2017
@torkelo torkelo changed the title [Bug] Mode options still apply to series override even if all Draw modes are unticked [UX] Don't hide graph display options (Lines/Points) when draw mode is unchecked Nov 2, 2017
@bergquist bergquist modified the milestones: 4.7.0, 5.0.0-beta1 Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants