Use Reader interface to fetch TLS certs and keys #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fayzal-g
force-pushed
the
secure-creds-from-vault
branch
from
eff5160
to
7a38715
Compare
fayzal-g
changed the title
fayzal-g
changed the title
fayzal-g
changed the title
fayzal-g
changed the title
pracucci
approved these changes
Mar 6, 2023
crypto/tls/tls.go
Outdated
| // read ca certificates | ||
| // If Reader interface not provided, default to reading from File | ||
| if cfg.Reader == nil { | ||
| cfg.Reader = &fileReader{} |
There was a problem hiding this comment.
I suggest to not overwrite cfg.Reader. You can just store the reader in a local variable.
There was a problem hiding this comment.
Good point, updated
pstibrany
approved these changes
Mar 6, 2023
3 tasks
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Uses a Reader interface to fetch secrets (certs/keys) used to configure TLS. Now allows reading not just from a file, but for anything that implements
ReadSecretFixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]