Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with config reload when using a log pipeline with a metric stage #6971

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Fix issue with config reload when using a log pipeline with a metric stage #6971

merged 4 commits into from
Jul 15, 2024

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Jun 27, 2024 •
edited
Loading

PR Description

There is a longstanding bug which prevents the agent config from being reloaded when there is a metrics stage in a logging pipeline.

Which issue(s) this PR fixes

Fixes #2754

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@ptodev ptodev force-pushed the ptodev/duplicate-metric-promtail branch 3 times, most recently from 9b54c7c to 9cd3ec8 Compare July 8, 2024 18:05
@ptodev ptodev mentioned this pull request Jul 9, 2024
Merged
4 tasks
@ptodev ptodev force-pushed the ptodev/duplicate-metric-promtail branch 2 times, most recently from 1657203 to 5b9c933 Compare July 11, 2024 12:52
@ptodev ptodev force-pushed the ptodev/duplicate-metric-promtail branch from 5b9c933 to 8f3ab0c Compare July 11, 2024 12:53
@ptodev ptodev marked this pull request as ready for review July 11, 2024 12:53
thampiotr
thampiotr reviewed Jul 12, 2024
View reviewed changes
internal/util/unregisterer.go Show resolved Hide resolved
internal/util/unregisterer.go Show resolved Hide resolved
static/traces/traces_test.go Show resolved Hide resolved
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Jul 12, 2024
ptodev and others added 3 commits July 12, 2024 16:07
@ptodev @clayton-cornell @thampiotr
Apply suggestions from code review
9eb4221 
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com>
@ptodev
Refactor Flow unit test to make it more readable.
9dd6c14
@ptodev
Add comments, prettify tests.
54980a9
@ptodev ptodev requested a review from thampiotr July 15, 2024 10:44
@ptodev ptodev merged commit 0936175 into main Jul 15, 2024
10 checks passed
@ptodev ptodev deleted the ptodev/duplicate-metric-promtail branch July 15, 2024 12:24
@ptodev ptodev mentioned this pull request Jul 15, 2024
Merged
4 tasks
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Aug 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thampiotr thampiotr thampiotr approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to unregister all metrics from previous promtail. THIS IS A BUG
3 participants
@ptodev @thampiotr @clayton-cornell