Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API end-point for edit application name and description #83

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

madding
Copy link
Contributor

@madding madding commented Nov 20, 2018

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #83   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          25     26    +1     
  Lines         767    785   +18     
=====================================
+ Hits          767    785   +18
Impacted Files Coverage Δ
router/router.go 100% <100%> (ø) ⬆️
api/application.go 100% <100%> (ø)
database/application.go 100% <100%> (ø) ⬆️
api/client.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee72391...c03ed84. Read the comment docs.

Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I really like the separation of the client and application api in different files.

There are only some minor things and a small bug to fix. Good work!

api/application.go Outdated Show resolved Hide resolved
api/application.go Outdated Show resolved Hide resolved
api/application.go Outdated Show resolved Hide resolved
api/application_test.go Outdated Show resolved Hide resolved
api/application_test.go Outdated Show resolved Hide resolved
api/token.go Show resolved Hide resolved
api/token.go Outdated Show resolved Hide resolved
router/router.go Show resolved Hide resolved
router/router.go Outdated Show resolved Hide resolved
router/router.go Show resolved Hide resolved
@madding
Copy link
Contributor Author

madding commented Nov 23, 2018

@jmattheis I fixed all notes.

@jmattheis
Copy link
Member

Thanks!

@jmattheis jmattheis merged commit 4a6863e into gotify:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants