Various stuff #43
Merged
Various stuff #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jmattheis
commented
Apr 3, 2018
jmattheis
commented
- Loading spinner on login
- When a client/user is deleted but the token is still saved in the browser, only one error message is shown
- Ensure that the websocket is only opened one time
- Only make the get users request if the user is an admin
- Show bad request messages
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 24 24
Lines 692 692
=====================================
Hits 692 692Continue to review full report at Codecov.
|
When a username already exists the api returns 400, this should be shown to the user.
jmattheis
force-pushed
the
try-authenticate
branch
from
c6e5578
to
3092421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.