Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Fix message image width to not exceed width of parent container #402

Merged
merged 2 commits into from
Mar 27, 2021

Conversation

MrLemur
Copy link
Contributor

@MrLemur MrLemur commented Mar 27, 2021

This adds a max-width to a message image, so that it does not go off the screen in the web UI. This is purely a cosmetic change in the web client's styling.

Fixes #259

This adds a `max-width` to a message image, so that it does not go off the screen in the web UI.
@MrLemur MrLemur requested a review from a team as a code owner March 27, 2021 12:40
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution! There are formatting errors, could you run yarn format inside the ui directory?

@MrLemur
Copy link
Contributor Author

MrLemur commented Mar 27, 2021

Looks good, thanks for your contribution! There are formatting errors, could you run yarn format inside the ui directory?

Done! That's nifty, I have gotten too used to formatting automatically on save.

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #402 (50b327f) into master (4c58f4a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files          44       44           
  Lines        1436     1436           
=======================================
  Hits         1277     1277           
  Misses         85       85           
  Partials       74       74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c58f4a...50b327f. Read the comment docs.

Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jmattheis jmattheis merged commit 346396f into gotify:master Mar 27, 2021
@MrLemur MrLemur deleted the fix-img-width branch March 27, 2021 13:04
@jmattheis jmattheis added this to the version+1 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Reduce image size
2 participants