Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use id provided from POST /message api #332

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Don't use id provided from POST /message api #332

merged 1 commit into from
Jun 23, 2020

Conversation

jmattheis
Copy link
Member

@jmattheis jmattheis added this to the version+1 milestone Jun 23, 2020
@jmattheis jmattheis requested a review from a team as a code owner June 23, 2020 15:17
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #332 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files          44       44           
  Lines        1721     1722    +1     
=======================================
+ Hits         1561     1562    +1     
  Misses         86       86           
  Partials       74       74
Impacted Files Coverage Δ
api/message.go 85.71% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a468b...fbde703. Read the comment docs.

@jmattheis jmattheis merged commit a9249bb into master Jun 23, 2020
@jmattheis jmattheis deleted the ignore-id branch June 23, 2020 16:39
@jmattheis jmattheis mentioned this pull request Jan 13, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternal-flame-AD eternal-flame-AD eternal-flame-AD approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v2.0.17
Development

Successfully merging this pull request may close these issues.
2 participants
@jmattheis @eternal-flame-AD