Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom ports in Docker healthcheck #321

Merged
merged 2 commits into from
May 29, 2020
Merged

Support custom ports in Docker healthcheck #321

merged 2 commits into from
May 29, 2020

Conversation

eikendev
Copy link
Contributor

Currently, the Docker container running with a custom port will always be shown unhealthy. This fix introduces a default port, which is overwritten when a user specifies a custom environment variable via Docker.

Please verify again that this works. I had to test a downstripped version, because my Podman didn't like it as is.

@eikendev eikendev requested a review from a team as a code owner May 28, 2020 08:49
jmattheis
jmattheis previously approved these changes May 28, 2020
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @eikendev, it works well.

@jmattheis jmattheis added this to the version+1 milestone May 28, 2020
@jmattheis
Copy link
Member

Build currently fails because (I guess) formatting errors inside generated files, I'll fix this tomorrow/on the weekend.

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #321 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files          44       44           
  Lines        1719     1719           
=======================================
  Hits         1561     1561           
  Misses         85       85           
  Partials       73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b30c5...6f128de. Read the comment docs.

@jmattheis jmattheis merged commit 52efbbc into gotify:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants