Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce ping interval #261

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Reduce ping interval #261

merged 1 commit into from
Jan 18, 2020

Conversation

jmattheis
Copy link
Member

Some reverse proxies have default timeouts of 60 seconds after they
close the websocket connetion.

Fixes #245

Some reverse proxies have default timeouts of 60 seconds after they
close the websocket connetion.

Fixes #245
@jmattheis jmattheis added this to the version+1 milestone Jan 18, 2020
@jmattheis jmattheis requested a review from a team as a code owner January 18, 2020 14:54
@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #261 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #261   +/-   ##
======================================
  Coverage    90.8%   90.8%           
======================================
  Files          43      43           
  Lines        1685    1685           
======================================
  Hits         1530    1530           
  Misses         83      83           
  Partials       72      72
Impacted Files Coverage Δ
router/router.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b56e0...eb4df44. Read the comment docs.

@jmattheis jmattheis merged commit 0a8fc47 into master Jan 18, 2020
@jmattheis jmattheis deleted the ping-interval branch January 18, 2020 15:17
@jmattheis jmattheis mentioned this pull request Feb 18, 2020
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

WebSocket: ReadError websocket: close 1006 (abnormal closure): unexpected EOF
1 participant