Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#214] Replace thrift dep from apache.org with github repo #216

Merged
merged 1 commit into from
Sep 4, 2019
Merged

[#214] Replace thrift dep from apache.org with github repo #216

merged 1 commit into from
Sep 4, 2019

Conversation

jmattheis
Copy link
Member

Fixes #214

@jmattheis jmattheis requested a review from a team as a code owner September 4, 2019 06:44
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files          43       43           
  Lines        1677     1677           
=======================================
  Hits         1524     1524           
  Misses         82       82           
  Partials       71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60ee06...b460de6. Read the comment docs.

@jmattheis jmattheis merged commit ede9cd6 into master Sep 4, 2019
@jmattheis jmattheis deleted the build branch September 4, 2019 17:41
@jmattheis jmattheis added this to the version+1 milestone Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternal-flame-AD eternal-flame-AD eternal-flame-AD approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v2.0.7
Development

Successfully merging this pull request may close these issues.

Cannot Build the Go App
2 participants
@jmattheis @eternal-flame-AD