Do not delete token on network error #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 40 40
Lines 1447 1447
=====================================
Hits 1447 1447Continue to review full report at Codecov.
|
ui/src/message/WebSocketStore.ts
Outdated
| @@ -42,6 +42,8 @@ export class WebSocketStore { | |||
| .catch((error: AxiosError) => { | |||
| if (error && error.response && error.response.status === 401) { | |||
| this.snack('Could not authenticate with client token, logging out.'); | |||
| } else { | |||
| this.snack('Lost network connection, please refresh the page.'); | |||
There was a problem hiding this comment.
I think this only displays once, right? So the user would have no idea that it is no longer connected to the server once he missed the initial notification. Can we schedule a reconnect here? Or at least add a persistent/repeating notification so that users can't miss it.
There was a problem hiding this comment.
I've added a banner with a retry button.
jmattheis
force-pushed
the
not-delete-token-on-network-error
branch
2 times, most recently
from
18f7a7f
to
727a515
Compare
jmattheis
force-pushed
the
not-delete-token-on-network-error
branch
from
727a515
to
0596674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.