Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use text for string storage in db #173

Merged
merged 1 commit into from
Mar 21, 2019
Merged

use text for string storage in db #173

merged 1 commit into from
Mar 21, 2019

Conversation

eternal-flame-AD
Copy link
Member

This fixes #97

@eternal-flame-AD eternal-flame-AD requested a review from a team as a code owner March 19, 2019 10:30
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #173   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          40     40           
  Lines        1447   1447           
=====================================
  Hits         1447   1447

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61578d4...fb7cb8f. Read the comment docs.

jmattheis
jmattheis approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following attributes are strings but haven't gotten a type:"text". While I agree, that these properties may mostly never be above 255 characters it is still inconsistent with the other databases.

model.User#Name
model.Application#Token
model.Client#Token
model.PluginConf#Token

@eternal-flame-AD
Copy link
Member Author

Yes, unique_index's can't use text type, as far as I know.

@jmattheis
Copy link
Member

Okay, I think it is better to let the author of the PR merge it to master, so feel free todo it (:.

@eternal-flame-AD
Copy link
Member Author

@jmattheis I can't merge to protected branches.

@jmattheis
Copy link
Member

Could you retry it?

@eternal-flame-AD eternal-flame-AD merged commit c89623a into gotify:master Mar 21, 2019
@jmattheis jmattheis added this to the version+1 milestone Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmattheis jmattheis jmattheis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v2.0.4
Development

Successfully merging this pull request may close these issues.

character limits with sqlite3
2 participants
@eternal-flame-AD @jmattheis