Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint and UI improvements to update client name #164

Merged
merged 2 commits into from
Mar 16, 2019
Merged

Endpoint and UI improvements to update client name #164

merged 2 commits into from
Mar 16, 2019

Conversation

GianOrtiz
Copy link
Contributor

Closes #101

@codecov
Copy link

codecov bot commented Mar 15, 2019 •
edited
Loading

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #164   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          39     39           
  Lines        1416   1429   +13     
=====================================
+ Hits         1416   1429   +13
Impacted Files Coverage Δ
api/client.go 100% <100%> (ø) ⬆️
database/client.go 100% <100%> (ø) ⬆️
router/router.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b3a0c...8ac8cbf. Read the comment docs.

@GianOrtiz
Copy link
Contributor Author

Waiting for the review @eternal-flame-AD 😃

eternal-flame-AD
eternal-flame-AD requested changes Mar 15, 2019
View reviewed changes
Copy link
Member

@eternal-flame-AD eternal-flame-AD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks:)

ui/src/client/ClientStore.ts Outdated Show resolved Hide resolved
ui/src/client/UpdateClientDialog.tsx Outdated Show resolved Hide resolved
ui/src/tests/client.test.ts Outdated Show resolved Hide resolved
ui/src/tests/client.test.ts Outdated Show resolved Hide resolved
jmattheis
jmattheis requested changes Mar 15, 2019
View reviewed changes
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've added some minor remarks.

ui/src/tests/client.test.ts Outdated Show resolved Hide resolved
api/client_test.go Outdated Show resolved Hide resolved
api/client.go Outdated Show resolved Hide resolved
api/client.go Outdated Show resolved Hide resolved
ui/src/client/UpdateClientDialog.tsx Outdated Show resolved Hide resolved
jmattheis
jmattheis approved these changes Mar 16, 2019
View reviewed changes
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmattheis jmattheis merged commit e32359e into gotify:master Mar 16, 2019
@jmattheis jmattheis added this to the v2.0.3 milestone Mar 16, 2019
@GianOrtiz GianOrtiz deleted the update-client-name branch March 18, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmattheis jmattheis jmattheis approved these changes

@eternal-flame-AD eternal-flame-AD eternal-flame-AD left review comments

Assignees
No one assigned
Labels
None yet
Milestone
v2.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@GianOrtiz @jmattheis @eternal-flame-AD