Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to go.mod #111

Merged
merged 1 commit into from
Jan 12, 2019
Merged

migrate to go.mod #111

merged 1 commit into from
Jan 12, 2019

Conversation

eternal-flame-AD
Copy link
Member

This PR migrated dependency management system from dep to go.mod

go.mod Outdated Show resolved Hide resolved
@jmattheis
Copy link
Member

The swagger spec generation sadly doesn't support go modules. We have to workaround this problem.

In the Makefile execute the swagger executable without go modules:

update-swagger:
	GO111MODULE=off swagger generate spec --scan-models -o docs/spec.json

After this the swagger executable will still not find the dependencies because they aren't on the gopath. So we somehow need to get the go mod dependencies there. The easiest solution I've found so far is to fill the vendor folder. So executing go mod vendor inside .travis.yml(install step) should work.

@eternal-flame-AD
Copy link
Member Author

Yeah, I think it would be good to write both commands in Makefile

@codecov
Copy link

codecov bot commented Jan 12, 2019

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #111   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines         806    806           
=====================================
  Hits          806    806

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19811da...eba1858. Read the comment docs.

go.sum Outdated Show resolved Hide resolved
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmattheis jmattheis merged commit 1070c5b into gotify:master Jan 12, 2019
@jmattheis jmattheis added this to the v1.3.0 milestone Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants