Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Suggested change to the flow of settings.html #57

Closed
wants to merge 1 commit into from
Closed

Suggested change to the flow of settings.html #57

wants to merge 1 commit into from

Conversation

GuardianMajor
Copy link

I told you I will mock up what I think would be a less busy interface, hope you like it.

I told you I will mock up what I think would be a less busy interface, hope you like it.
@gorhill
Copy link
Owner

gorhill commented Nov 18, 2013

Thank you very much, this will be part of the next version. I just imported manually the changes because I had to edit stuff and I already had committed stuff also. Javascript cannot be inlined in an extension, there has to be a clear separation between html and js (which is good imo), and also I use jquery so I could simplify by also reworking the css (margin, padding, alignment etc.) I kept the look though, it's neat.

@gorhill
Copy link
Owner

gorhill commented Nov 18, 2013

Manually imported, in v0.5.6

@gorhill gorhill closed this Nov 18, 2013
@GuardianMajor
Copy link
Author

You are welcome my dear friend, glad it could help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants