-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add sample with some more features using Next JS (React + TS) #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future additions like this (and this one if you're able), could you add a screenshot or gif to the PR description?
addons-web-sdk/samples/animation-next-js/src/components/prettyColors.css
Show resolved
Hide resolved
I'm a bit wary of posting screenshots to a public site because the add-on is currently only published for people with @google.com domains, and posting screenshots of my corp version of Google Meet could potentially leak something. But, you can see the animation live at https://googleworkspace.github.io/meet/animation-next-js/mainstage.html, and the side panel live at https://googleworkspace.github.io/meet/animation-next-js/sidepanel.html Googlers can also screenshare https://googleworkspace.github.io/meet/animation-next-js/ from prod Meet, and it will prompt them to install the add-on. So you can also test it yourself! I would like to publish this one publicly, but need to talk through the details there... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting up eslint+prettier is non-trivial amount of work so I'm not recommending that for a sample add-on, but we should scan through the files to make sure we're consistently using 2-space indents, single quotes, and 80 character lines.
addons-web-sdk/samples/animation-next-js/src/app/mainstage/page.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much azizj@!
addons-web-sdk/samples/animation-next-js/src/components/prettyColors.css
Outdated
Show resolved
Hide resolved
addons-web-sdk/samples/animation-next-js/src/shared/constants.ts
Outdated
Show resolved
Hide resolved
addons-web-sdk/samples/animation-next-js/src/shared/constants.ts
Outdated
Show resolved
Hide resolved
addons-web-sdk/samples/animation-next-js/src/shared/constants.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks so much Teddy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caught something - thanks again
This is quite similar to #15, but also includes:
The idea is that I can link this add-on from all three of those pages, and dramatically shorten the content of https://developers.google.com/meet/add-ons/guides/use-SDK to only cover the "hello world" features of #15
Edit: if you screenshare https://googleworkspace.github.io/meet/animation-next-js/ from prod Meet, you should see a (slightly outdated) version of this in action