feat: Adding Kotlin version of PolyActivity #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
arriolac
changed the title
barbeau
reviewed
May 11, 2020
tutorials/java/Polygons/README.md
Outdated
| This demo app requires that you add your own Google Maps API key: | ||
|
|
||
| 1. [Get a Maps API key](https://developers.google.com/maps/documentation/android-sdk/get-api-key) | ||
| 1. Create a file in the `tutorials/java/Polygons` directory called `secure.properties` |
There was a problem hiding this comment.
Should be "...tutorials/java/Polygons/app". Same with step below.
tutorials/kotlin/Polygons/README.md
Outdated
| This demo app requires that you add your own Google Maps API key: | ||
|
|
||
| 1. [Get a Maps API key](https://developers.google.com/maps/documentation/android-sdk/get-api-key) | ||
| 1. Create a file in the `tutorials/kotlin/Polygons` directory called `secure.properties` |
There was a problem hiding this comment.
Same here - this and below step should be tutorials/kotlin/Polygons/app
| implementation "androidx.core:core-ktx:+" | ||
| implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version" | ||
| } | ||
| repositories { |
There was a problem hiding this comment.
I believe you can remove mavenCentral() dependency.
| // Top-level build file where you can add configuration options common to all sub-projects/modules. | ||
|
|
||
| buildscript { | ||
| ext.kotlin_version = '1.3.72' |
There was a problem hiding this comment.
Will dependabot catch dependencies to bump that have the version number pull out like this?
There was a problem hiding this comment.
Unfortunately this won't be captured by Dependabot. There's an issue here that's been marked as stale: dependabot/dependabot-core#1618
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kikoso
pushed a commit
that referenced
this pull request
Aug 14, 2024
* chore: Modify how API key is provided * Creating kotlin version of Polygons. * Add region tag for maps_poly_activity_get_map_async * Add region tag for maps_poly_activity_on_map_ready * Add region tag for maps_poly_activity_add_polyline * Add region tag for maps_poly_activity_add_polyline_set_tag * Add regiontag maps_poly_activity_style_polyline * Add region tag for maps_poly_activity_on_polyline_click * Add region tag for maps_poly_activity_style_polygon * Addressing comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Kotlin version of tutorial PolyActivity found in https://developers.google.com/maps/documentation/android-sdk/polygon-tutorial
This change also adds the following region tags: