Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GameServer UpdateStatus() since its not being used. #959

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Remove GameServer UpdateStatus() since its not being used. #959

merged 1 commit into from
Jul 30, 2019

Conversation

markmandel
Copy link
Member

Also included documentation on why we don't provide a status subresource.

Fixes #329

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jul 29, 2019
@markmandel markmandel mentioned this pull request Jul 29, 2019
Closed
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5a82bfd7-1271-4e91-b409-e2c6f81ea4a1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/959/head:pr_959 && git checkout pr_959
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-aa163df

@markmandel markmandel mentioned this pull request Jul 30, 2019
Closed
@markmandel
Remove GameServer UpdateStatus() since its not being used.
da81414 
Also included documentation on why we don't provide a status
subresource.
@markmandel markmandel marked this pull request as ready for review July 30, 2019 08:13
@markmandel markmandel added this to the 0.12.0 milestone Jul 30, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 165ca3b7-3c21-4962-91df-464a9a620423

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/959/head:pr_959 && git checkout pr_959
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-da81414

@markmandel markmandel merged commit 65463e5 into googleforgames:master Jul 30, 2019
@markmandel markmandel deleted the cleanup/gs-no-status branch July 30, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Move to using CRD Subresources for all Agones CRDs
3 participants
@markmandel @agones-bot @roberthbailey