Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gen-sdk-grpc make target name. #873

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Update gen-sdk-grpc make target name. #873

merged 2 commits into from
Jul 9, 2019

Conversation

roberthbailey
Copy link
Member

I was going through some of the make targets and realized this one had had a name change but the docs weren't updated.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 58a01a34-05cd-43c4-a7eb-0533d356e15a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel
markmandel approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Jul 9, 2019
@markmandel markmandel added this to the 0.12.0 milestone Jul 9, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2957bcd3-0536-457c-90d8-dfb154229f9e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/873/head:pr_873 && git checkout pr_873
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-f8ae7e9

@markmandel markmandel merged commit 79b4deb into googleforgames:master Jul 9, 2019
@roberthbailey roberthbailey mentioned this pull request Jul 16, 2019
Closed
5 tasks
@roberthbailey roberthbailey deleted the make-target branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@roberthbailey @agones-bot @markmandel