Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unity example #860

Merged
merged 2 commits into from
Jul 15, 2019
Merged

add unity example #860

merged 2 commits into from
Jul 15, 2019

Conversation

whisper0077
Copy link
Contributor

Add Unity example (#246)

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d4313302-8fa7-4326-a64b-c70d0744995b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: eaa3eed9-9076-4564-afb1-3ab0e62c2a91

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel
markmandel reviewed Jul 1, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore the CI failures, it's being flaky.

@dzlier-gcp can you review this? I had a couple of comments, but you are our resident Unity expert 😄

examples/unity-simple/README.md Outdated Show resolved Hide resolved
examples/unity-simple/Makefile Show resolved Hide resolved
examples/unity-simple/Assets/Scripts/UdpEchoController.cs Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9b4c8267-511b-4ac7-bac5-51f8a80bbfb9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: eb879d9f-e6b4-4a96-9f58-1b959c11e727

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 675780d8-c646-49f8-885a-2091f90f4b53

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/860/head:pr_860 && git checkout pr_860
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-bf8653c

dzliergaard
dzliergaard reviewed Jul 9, 2019
View reviewed changes
Copy link

@dzliergaard dzliergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One general note, please make sure there are newlines at the end of all script files.

examples/unity-simple/Assets/Scripts/Editor/BatchBuild.cs Outdated Show resolved Hide resolved
examples/unity-simple/Assets/Scripts/Editor/BatchBuild.cs Show resolved Hide resolved
examples/unity-simple/Assets/Scripts/UdpEchoClient.cs Outdated Show resolved Hide resolved
examples/unity-simple/Assets/Scripts/UdpEchoController.cs Show resolved Hide resolved
examples/unity-simple/Assets/Scripts/UdpEchoClient.cs Outdated Show resolved Hide resolved
examples/unity-simple/Assets/Scripts/UdpEchoServer.cs Outdated Show resolved Hide resolved
@whisper0077
Copy link
Contributor Author

whisper0077 commented Jul 13, 2019 •
edited
Loading

I fixed reviews and rebase commits.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e322420a-5059-4937-ba7e-ac92ce38b683

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 398bd80b-d168-4980-b0c7-ee3dc2d423be

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ff15bc8a-39c3-426d-9c52-ca1350fa256a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/860/head:pr_860 && git checkout pr_860
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-4b3c5ad

@markmandel markmandel added this to the 0.12.0 milestone Jul 15, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d01f727d-d620-44a5-92cc-e6915fd666f1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/860/head:pr_860 && git checkout pr_860
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-d504c19

@markmandel markmandel merged commit 5904de8 into googleforgames:master Jul 15, 2019
@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel left review comments

@dzliergaard dzliergaard dzliergaard approved these changes

@dzlier-gcp dzlier-gcp dzlier-gcp approved these changes

Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@whisper0077 @agones-bot @markmandel @dzliergaard @dzlier-gcp