Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: TestHealthControllerRun #816

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Flaky: TestHealthControllerRun #816

merged 2 commits into from
Jun 11, 2019

Conversation

markmandel
Copy link
Member

Took another look at this rarely flaky test - I think I worked out some potential causes.

Along the way, I realised we could also be doing some better sync and health checking, which should hopefully also helps stop the test flakiness.

@markmandel
Flaky: TestHealthControllerRun
5840c0c 
Took another look at this rarely flaky test - I think I worked out some
potential causes.

Along the way, I realised we could also be doing some better sync and
health checking, which should hopefully also helps stop the test
flakiness.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jun 6, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 169cdcd9-20ce-45b4-bbf5-10d1237881c5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/816/head:pr_816 && git checkout pr_816
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-5840c0c

ilkercelikyilmaz
ilkercelikyilmaz approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@ilkercelikyilmaz ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel added this to the 0.11.0 milestone Jun 11, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 88561a01-8440-4ec1-b303-7d027be63006

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/816/head:pr_816 && git checkout pr_816
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-870937b

@markmandel markmandel merged commit e5229d5 into googleforgames:master Jun 11, 2019
@markmandel markmandel deleted the flaky/TestHealthControllerRun branch June 11, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkercelikyilmaz ilkercelikyilmaz ilkercelikyilmaz approved these changes

Assignees
No one assigned
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @ilkercelikyilmaz